ARROW-12944: [C++] String capitalize kernel #10857
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pitrou
requested changes
Aug 3, 2021
edponce
force-pushed
the
ARROW-12944-String-capitalize-kernel
branch
from
c1b73ae
to
6ae88fd
Compare
pitrou
reviewed
Aug 4, 2021
pitrou
approved these changes
Aug 4, 2021
pitrou
force-pushed
the
ARROW-12944-String-capitalize-kernel
branch
from
18c4f01
to
9d7f298
Compare
|
Rebased, will merge if green. |
edponce
force-pushed
the
ARROW-12944-String-capitalize-kernel
branch
from
9d7f298
to
4f82d0d
Compare
|
@pitrou I pushed a change after you rebased, so I will fix conflicts and re-push. |
|
Hmm, another commit was lost then... |
|
Recommend starting from 9d7f298 and then applying the buffer overflow fix. |
edponce
force-pushed
the
ARROW-12944-String-capitalize-kernel
branch
from
4f82d0d
to
997919e
Compare
|
Some tests invoke the incorrect kernel (ASCII test uses |
michalursa
pushed a commit
to michalursa/arrow
that referenced
this pull request
Aug 17, 2021
This PR adds scalar compute functions for string capitalization, namely "ascii_capitalize" and "utf8_capitalize". Closes apache#10857 from edponce/ARROW-12944-String-capitalize-kernel Authored-by: Eduardo Ponce <edponce00@gmail.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds scalar compute functions for string capitalization, namely "ascii_capitalize" and "utf8_capitalize".