ARROW-3699: [C++] Dockerfile for testing 32-bit C++ build #10865
Conversation
ci/docker/debian-10-cpp.dockerfile
Outdated
| @@ -73,7 +73,9 @@ RUN apt-get update -y -q && \ | |||
|
|
|||
| COPY ci/scripts/install_minio.sh \ | |||
| /arrow/ci/scripts/ | |||
| RUN /arrow/ci/scripts/install_minio.sh ${arch} linux latest /usr/local | |||
| RUN if [ "${arch}" != "i386" ]; then \ | |||
| /arrow/ci/scripts/install_minio.sh ${arch} linux latest /usr/local; \ | |||
There was a problem hiding this comment.
Can't find a binary for i386 here: https://dl.min.io/server/minio/release/
Possibly need to set ARROW_S3=OFF as well.
There was a problem hiding this comment.
Probably because nobody cares :-)
There was a problem hiding this comment.
Instead of putting the if here, put it in the download script?
There's a test failure, but apart from that it worked. |
|
Thanks for checking it! Going to submit the crossbow task and if it works we can create follow-up tickets and start exercising i386 builds. |
|
@github-actions crossbow submit test-debian-10-cpp-i386 |
|
Revision: e8a466f Submitted crossbow builds: ursacomputing/crossbow @ actions-712
|
|
There is a failing test case, but the overall build configuration works. @kou shall we configure i386 builds for other distributions as well? |
|
I don't think that we need more i386 builds. |
|
@github-actions crossbow submit test-debian-10-cpp-i386 |
|
Revision: 08c7b63 Submitted crossbow builds: ursacomputing/crossbow @ actions-847
|
|
@github-actions crossbow submit test-debian-* |
|
Revision: 0e2dcd0 Submitted crossbow builds: ursacomputing/crossbow @ actions-1211
|
|
@github-actions crossbow submit test-debian-11-cpp-* |
|
Revision: 6037613 Submitted crossbow builds: ursacomputing/crossbow @ actions-1212
|
|
@github-actions crossbow submit test-debian-10-cpp-* |
|
Revision: 6037613 Submitted crossbow builds: ursacomputing/crossbow @ actions-1213
|
ci/docker/debian-10-cpp.dockerfile
Outdated
| @@ -73,7 +73,9 @@ RUN apt-get update -y -q && \ | |||
|
|
|||
| COPY ci/scripts/install_minio.sh \ | |||
| /arrow/ci/scripts/ | |||
| RUN /arrow/ci/scripts/install_minio.sh ${arch} linux latest /usr/local | |||
| RUN if [ "${arch}" != "i386" ]; then \ | |||
| /arrow/ci/scripts/install_minio.sh ${arch} linux latest /usr/local; \ | |||
There was a problem hiding this comment.
Instead of putting the if here, put it in the download script?
| @@ -3451,7 +3451,7 @@ TEST_F(TestInt64QuantileKernel, Int64) { | |||
| #undef DOUBLE | |||
| #undef O | |||
|
|
|||
| #ifndef __MINGW32__ | |||
| #if ARROW_BITNESS != 32 | |||
There was a problem hiding this comment.
Instead of skipping this on all 32-bit platforms, can you skip only on x86?
|
@github-actions crossbow submit test-debian--cpp- |
|
Revision: 24583f0 Submitted crossbow builds: ursacomputing/crossbow @ actions-1230
|
|
@github-actions crossbow submit test-debian-10-cpp-* |
|
Revision: 753e38a Submitted crossbow builds: ursacomputing/crossbow @ actions-1231
|
|
@github-actions crossbow submit test-debian--cpp- |
|
Revision: 738828d Submitted crossbow builds: ursacomputing/crossbow @ actions-1233
|
|
Benchmark runs are scheduled for baseline = be9a22b and contender = 0da15b6. 0da15b6 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
I'm not sure whether this is going to work on a amd64 linux host, but it actually runs on docker for mac.
@pitrou could you please try
locally?