ARROW-13574: [C++] Add 'count all' option to count kernels #10895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm... It's weird that Can we instead make |
|
Rebased, fixed conflicts, added CountOptions, added GLib/Python/R bindings for CountOptions. |
lidavidm
changed the title
pitrou
reviewed
Aug 10, 2021
| /// Count only non-null values. | ||
| NON_NULL = 0, | ||
| /// Count only null values. | ||
| NULLS, |
There was a problem hiding this comment.
Nit, but the plural / singular is a bit inconsistent. Perhaps ONLY_NULL vs ONLY_VALID (or NULLS vs NON_NULLS, or NULL_VALUES vs VALID_VALUES...)?
| *out = Datum(state.nulls); | ||
| break; | ||
| case CountOptions::ALL: | ||
| *out = Datum(state.non_nulls + state.nulls); |
There was a problem hiding this comment.
In this case, it's probably not necessary to popcount the null bitmap?
| @@ -562,7 +570,7 @@ const FunctionDoc count_doc{"Count the number of null / non-null values", | |||
| ("By default, only non-null values are counted.\n" | |||
| "This can be changed through ScalarAggregateOptions."), | |||
pitrou
approved these changes
Aug 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pandas calls this 'size'. I opted not to extend ScalarAggregateOptions as the option wouldn't apply to any other kernel.