ARROW-9616: [C++][R] Remove templated base classes named /.*ConcurrencyWrapper/
#10914
Conversation
| shell: Rscript {0} | ||
| run: | | ||
| dir.create("~/.R") | ||
| writeLines(c("CPPFLAGS=-flto", "AR=gcc-ar", "NM=gcc-nm", "RANLIB=gcc-ranlib"), "~/.R/Makevars") |
There was a problem hiding this comment.
Won't this make builds even slower?
|
I'm ok with the C++ changes in principle, though it doesn't seem to appease the R build. |
|
@bkietz seems to have solved most errors, but still 1 remaining: https://gist.github.com/jeroen/0c8bbfcdc51c6ac6d0672a3ca164e532 Btw I am testing this with the new upcoming gcc-10 toolchain, I don't think it is needed to enable this in your CI with rtools4 at this point. |
|
@pitrou it's actually a compiler error. Still a problem, though |
|
What is the status on this, I'm assuming the underlying issue has been fixed otherwise? |
|
No the issue still exists for arrow 6.0.0. The fix by @bkietz had fixed the problem for 90%, there was only 1 remaining lto error. However this is not very important, I use an experimental next-gen toolchain to test this. |
This is a guess; Windows assumptions about linkage + templated base classes have been problematic in the past