ARROW-13638: [C++] Hold owned copy of function options in GroupByNode #10947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkietz
approved these changes
Aug 17, 2021
| @@ -256,14 +256,16 @@ struct GroupByNode : ExecNode { | |||
| const std::vector<int>&& key_field_ids, | |||
| const std::vector<int>&& agg_src_field_ids, | |||
| const std::vector<internal::Aggregate>&& aggs, | |||
| const std::vector<const HashAggregateKernel*>&& agg_kernels) | |||
| const std::vector<const HashAggregateKernel*>&& agg_kernels, | |||
There was a problem hiding this comment.
If you wouldn't mind cleaning this up:
Suggested change
| const std::vector<const HashAggregateKernel*>&& agg_kernels, | |
| std::vector<const HashAggregateKernel*> agg_kernels, |
also ExecNode subclasses shouldn't be structs
bkietz
approved these changes
Aug 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GroupByNode lazily initializes per-thread kernel state, so it needs an owned copy of function options to do so.