ARROW-13789: [Go] Implement Scalar Values for Go #11024
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bump @emkornfield @sbinet |
emkornfield
reviewed
Sep 2, 2021
emkornfield
reviewed
Sep 2, 2021
|
Sorry didn't finish reviewing, will try to finish review over the next week or two. |
|
@emkornfield any luck? |
| } | ||
|
|
||
| if !l.Valid { | ||
| return |
There was a problem hiding this comment.
do you want to set an err in this case?
There was a problem hiding this comment.
that case isn't an error, it just means it's a null scalar
|
@emkornfield do you have any objections to me merging this? |
|
sorry have not had a chance to look yet. |
asfgit
pushed a commit
that referenced
this pull request
Sep 22, 2021
This is needed for adding nested types to the `MakeArrayFromScalar` function in ARROW-13789 (#11024) @emkornfield @sbinet @fsaintjacques Closes #11128 from zeroshade/concat_arrays Lead-authored-by: Matthew Topol <mtopol@factset.com> Co-authored-by: Matt Topol <mtopol@factset.com> Signed-off-by: Matthew Topol <mtopol@factset.com>
|
@emkornfield Do you have any objections to me merging this for now so i can continue the development and it can be further reviewed later as I add more things? I'm still trying to keep the PRs smaller where possible so i don't want to just add more stuff to this PR |
|
sorry, yes, I think merging is fine, I'll try to get some time to review. |
ViniciusSouzaRoque
pushed a commit
to s1mbi0se/arrow
that referenced
this pull request
Oct 20, 2021
This is needed for adding nested types to the `MakeArrayFromScalar` function in ARROW-13789 (apache#11024) @emkornfield @sbinet @fsaintjacques Closes apache#11128 from zeroshade/concat_arrays Lead-authored-by: Matthew Topol <mtopol@factset.com> Co-authored-by: Matt Topol <mtopol@factset.com> Signed-off-by: Matthew Topol <mtopol@factset.com>
ViniciusSouzaRoque
pushed a commit
to s1mbi0se/arrow
that referenced
this pull request
Oct 20, 2021
In preparation for trying to expose the Compute APIs vs CGO, first we need to have Scalar values implemented. After this, we can implement compatible Expression tree handling for serializing between the C++ and the Golang Closes apache#11024 from zeroshade/scalars Lead-authored-by: Matthew Topol <mtopol@factset.com> Co-authored-by: Matt Topol <mtopol@factset.com> Signed-off-by: Matthew Topol <mtopol@factset.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for trying to expose the Compute APIs vs CGO, first we need to have Scalar values implemented. After this, we can implement compatible Expression tree handling for serializing between the C++ and the Golang