ARROW-13916: [C++] Implement strftime on date32/64 types #11219
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rok
force-pushed
the
ARROW-13916
branch
3 times, most recently
from
c4cc286
to
e50eb84
Compare
| @@ -566,6 +566,14 @@ TEST_F(ScalarTemporalTest, Strftime) { | |||
| utf8(), string_microseconds, &options); | |||
| CheckScalarUnary("strftime", timestamp(TimeUnit::NANO, "US/Hawaii"), nanoseconds, | |||
| utf8(), string_nanoseconds, &options); | |||
|
|
|||
| auto options2 = StrftimeOptions("%Y-%m-%d"); | |||
There was a problem hiding this comment.
Can you also add a test with formatting hours/minutes/seconds? (I suppose those will just work, with all 0?)
rok
force-pushed
the
ARROW-13916
branch
7 times, most recently
from
21c0bad
to
23b6bd2
Compare
pitrou
approved these changes
Sep 27, 2021
ViniciusSouzaRoque
pushed a commit
to s1mbi0se/arrow
that referenced
this pull request
Oct 20, 2021
This is to resolve [ARROW-13916](https://issues.apache.org/jira/browse/ARROW-13916). Closes apache#11219 from rok/ARROW-13916 Authored-by: Rok <rok@mihevc.org> Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to resolve ARROW-13916.