ARROW-14106: [Go][C] Implement Exporting to the C Data Interface #11220
Conversation
| assert sc == self.make_schema() | ||
|
|
||
| def test_get_batch(self): | ||
| with self.assert_pyarrow_memory_released(): |
There was a problem hiding this comment.
Is there also a way to check that all Go memory was released?
There was a problem hiding this comment.
We have an "allocator" object in the Go that I could expose a reference to for the tests which would then provide a way to check that the Go memory got freed. I'll see what i can do, but that's a really good point. It also ties into #11206 a bit where I set up a way to directly use and reference the MemoryPool in the C++ from Go
There was a problem hiding this comment.
added a CurrentAlloc function to the CheckedAllocator and have everything in the test use that in order to expose a function that allows confirming the Go memory has been released.
|
@pitrou any further comments on this one too? |
|
@pitrou Thanks for the review, and I know you're not a Go developer but it seems i haven't been able to get any other Go developers reliably commenting on these and Go isn't particularly difficult to pick up or understand so I'll take it :) |
CC @pitrou @emkornfield Closes apache#11220 from zeroshade/arrow-14106 Lead-authored-by: Matthew Topol <mtopol@factset.com> Co-authored-by: Matt Topol <mtopol@factset.com> Signed-off-by: Matthew Topol <mtopol@factset.com>
CC @pitrou @emkornfield