ARROW-14124: [R] Timezone support in R <= 3.4 #11250
Conversation
|
|
|
@github-actions crossbow submit test-r-versions |
|
Revision: 995ff93 Submitted crossbow builds: ursacomputing/crossbow @ actions-856
|
|
|
||
| # See comment regarding %S flag in strftime tests | ||
| expect_dplyr_equal( | ||
| input %>% | ||
| mutate(x = format_ISO8601(x, precision = "ymdhms", usetz = TRUE)) %>% | ||
| mutate(x = format_ISO8601(x, precision = "ymdhms", usetz = FALSE)) %>% |
There was a problem hiding this comment.
This diff and the one above it make this a bit confusing. What I actually did was moved the usetz = FALSE block up above into the if/else gated on R version. But git took that to mean I deleted the usetz = FALSE and then changed the FALSE to TRUE here.
Both cases are still in this file, and for anything R 3.5 and higher we test that it works, for < 3.5 we test the error
There was a problem hiding this comment.
I don't see usetz = FALSE in the green if/else above, they all say TRUE, am I missing something?
There was a problem hiding this comment.
Right, the error only happens when usetz = TRUE (hence those are the only ones in the if/else). With use tz = FALSE arrow can (and does) strftime() without complaint.
Closes apache#11250 from jonkeane/r-timezone-34 Authored-by: Jonathan Keane <jkeane@gmail.com> Signed-off-by: Neal Richardson <neal.p.richardson@gmail.com>
No description provided.