ARROW-14157: [C++] Refactor Abseil to its own macro #11261
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We will need Abseil for the GCS C++ SDK (aka `google-cloud-cpp`), so split it to its own macro. Use the `abseil_ep` target as a sentinel to make the macro idempotent. Abseil creates many (over 100) libraries, each relatively small. These libraries depend on each other. Document how to extract this information using a shell command-line for future updates. We will not need all these libraries, but it is easier to describe all their dependencies that pick and choose which ones are used.
|
|
|
|
kou
reviewed
Sep 28, 2021
| "absl::config;absl::type_traits") | ||
| set_target_properties(absl::base | ||
| PROPERTIES INTERFACE_LINK_LIBRARIES | ||
| "absl::atomic_hook;absl::base_internal;absl::config;absl::core_headers;absl::dynamic_annotations;absl::log_severity;absl::raw_logging_internal;absl::spinlock_wait;absl::type_traits" |
There was a problem hiding this comment.
This list is very long.
How about using set_property(TARGET absl:... PROPERTY INTERFACE_LINK_LIBRARIES absl::... absl:: ...) https://cmake.org/cmake/help/latest/command/set_property.html#command:set_property ?
There was a problem hiding this comment.
Thanks, that is a good idea. Let me test that locally while the other builds run.
|
@github-actions crossbow submit -g nightly |
|
Revision: 1d83c28 Submitted crossbow builds: ursacomputing/crossbow @ actions-858
|
pitrou
reviewed
Sep 29, 2021
| set(ABSL_BUILD_BYPRODUCTS) | ||
| set(ABSL_LIBRARIES) | ||
|
|
||
| # Abseil produces the following libraries, each is fairly small, but there |
There was a problem hiding this comment.
For the record, since most of the declarations below could be generated by a script, perhaps they could be factored out into a separate CMake inclusion file? That would also reduce clutter in this file.
ViniciusSouzaRoque
pushed a commit
to s1mbi0se/arrow
that referenced
this pull request
Oct 20, 2021
We will need Abseil for the GCS C++ SDK (aka `google-cloud-cpp`), so split it to its own macro. Use the `abseil_ep` target as a sentinel to make the macro idempotent. Abseil creates many (over 100) libraries, each relatively small. These libraries depend on each other. Document how to extract this information using a shell command-line for future updates. We will not need all these libraries, but it is easier to describe all their dependencies that pick and choose which ones are used. Closes apache#11261 from coryan/ARROW-14157-refactor-abseil-dependency Authored-by: Carlos O'Ryan <coryan@google.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We will need Abseil for the GCS C++ SDK (aka
google-cloud-cpp), sosplit it to its own macro. Use the
abseil_eptarget as a sentinel tomake the macro idempotent.
Abseil creates many (over 100) libraries, each relatively small. These
libraries depend on each other. Document how to extract this information
using a shell command-line for future updates. We will not need all
these libraries, but it is easier to describe all their dependencies
that pick and choose which ones are used.