You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was omitted from ARROW-13390. Note that even after this, there's work for ARROW-14105 to unify the type promotion rules and make them apply to dictionary indices/values as well. Contains some changes from ARROW-13358 and also updates case_when's promotion rules a bit.
I pushed an addition to the R tests that verifies that this works from the R bindings.
ianmcook
changed the title
ARROW-14167: [C++] Directly support dictionaries in coalesce
ARROW-14167: [C++][R] Directly support dictionaries in coalesce
Nov 9, 2021
Benchmark runs are scheduled for baseline = bb776d8 and contender = 575a437. 575a437 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.0% ⬆️0.53%] ursa-i9-9960x
[Finished ⬇️0.13% ⬆️0.0%] ursa-thinkcentre-m75q
Supported benchmarks:
ursa-i9-9960x: langs = Python, R, JavaScript
ursa-thinkcentre-m75q: langs = C++, Java
ec2-t3-xlarge-us-east-2: cloud = True
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lidavidm
force-pushed
the
arrow-14167
branch
2 times, most recently
from
ianmcook
changed the title
This was omitted from ARROW-13390. Note that even after this, there's work for ARROW-14105 to unify the type promotion rules and make them apply to dictionary indices/values as well. Contains some changes from ARROW-13358 and also updates case_when's promotion rules a bit.