Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-8621: [Release] Add post release step to add tags for Go versioning #11312

Closed
wants to merge 3 commits into from

Conversation

zeroshade
Copy link
Member

@zeroshade zeroshade commented Oct 4, 2021

Adding a new post script for adding the tags needed for pkg.go.dev to recognize the package versioning for the Golang modules for arrow and parquet

@github-actions
Copy link

github-actions bot commented Oct 4, 2021

@zeroshade
Copy link
Member Author

Also, specifically I wanted to get this in in time for the 6.0.0 release to hopefully get that versioned properly in Go via the tags

@kou kou changed the title ARROW-8621: Add Post release step to add tags for Go versioning ARROW-8621: [Release] Add Post release step to add tags for Go versioning Oct 5, 2021
@kou kou changed the title ARROW-8621: [Release] Add Post release step to add tags for Go versioning ARROW-8621: [Release] Add post release step to add tags for Go versioning Oct 5, 2021
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added all permissions on https://cwiki.apache.org/confluence/display/ARROW/ to you.

post-13-go.sh is OK. 01-prepare.sh isn't suitable because it's used in RC release process.

Could you update this pull request's description to be usable for commit message?

dev/release/post-13-go.sh Outdated Show resolved Hide resolved
dev/release/post-13-go.sh Outdated Show resolved Hide resolved
Matt Topol and others added 2 commits October 5, 2021 09:21
use apache instead of origin as the remote name

Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
ensure pointing Go tags to the same commit as the tagged arrow version

Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
@zeroshade
Copy link
Member Author

@kou Updated the description and your suggestions. I'll update the confluence

@zeroshade
Copy link
Member Author

@kou Confluence updated, please let me know if there's anything else i need to do (or if there's any issue with my added task of "Updating tags for Go modules" to the confluence.)

@kou
Copy link
Member

kou commented Oct 5, 2021

Thanks. I've confirmed.

https://cwiki.apache.org/confluence/display/ARROW/Release+Management+Guide

The script assumes the remote name is apache and does not push the tags itself, that needs to be done manually after running it.

The script pushes the tags automatically by the last 2 lines. Which behavior do you expect?

@zeroshade
Copy link
Member Author

@kou Gah, I completely forgot about that. Is there a preference? If not, I'd prefer having it push the tags automatically in the script just to ensure it happens. (I'll update the confluence accordingly)

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

I'm OK with pushing tags automatically.

@kou kou closed this in 7d43b74 Oct 5, 2021
@zeroshade zeroshade deleted the arrow-8621-go-versioning branch October 20, 2021 16:46
ViniciusSouzaRoque pushed a commit to s1mbi0se/arrow that referenced this pull request Oct 20, 2021
…ning

Adding a new post script for adding the tags needed for pkg.go.dev to recognize the package versioning for the Golang modules for arrow and parquet

Closes apache#11312 from zeroshade/arrow-8621-go-versioning

Lead-authored-by: Matt Topol <mtopol@factset.com>
Co-authored-by: Matthew Topol <mtopol@factset.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants