Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-14252 [R] Partial matching of arguments warning #11371

Closed

Conversation

dragosmg
Copy link
Contributor

@dragosmg dragosmg commented Oct 8, 2021

No description provided.

@github-actions
Copy link

github-actions bot commented Oct 8, 2021

@nealrichardson
Copy link
Contributor

Isn't there an option about warning about partial matching? Can/should we turn this on in our CI somewhere (like around here)?

@dragosmg
Copy link
Contributor Author

dragosmg commented Oct 8, 2021

I have the option switched on in my .Rprofile as options(warnPartialMatchArgs = TRUE). I had forgotten about it.

@dragosmg
Copy link
Contributor Author

dragosmg commented Oct 8, 2021

We could try and set the option similar to the {lintr} CI here. Should we make it part of this or a separate PR?

@nealrichardson
Copy link
Contributor

Could we add it to the .Rprofile we use in most of our CI jobs? https://github.com/apache/arrow/blob/master/ci/etc/rprofile#L44

@jonkeane ?

@dragosmg
Copy link
Contributor Author

dragosmg commented Oct 8, 2021

I hadn't realised there is a project-level .Rprofile. That might be the best place for it. Usually these 3 options go hand-in-hand:

options(
    warnPartialMatchAttr = TRUE,
    warnPartialMatchDollar = TRUE,
    warnPartialMatchArgs = TRUE
)

@nealrichardson
Copy link
Contributor

Feel free to add those and let's see what happens

Copy link
Contributor

@nealrichardson nealrichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! CI failures seem unrelated

@ursabot
Copy link

ursabot commented Oct 11, 2021

Benchmark runs are scheduled for baseline = b9b181d and contender = ca18e8a. ca18e8a is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.0% ⬆️0.0%] ursa-thinkcentre-m75q
Supported benchmarks:
ursa-i9-9960x: langs = Python, R, JavaScript
ursa-thinkcentre-m75q: langs = C++, Java
ec2-t3-xlarge-us-east-2: cloud = True

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants