Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-14301: [C++] use consistent CMAKE_CXX_STANDARD definition #11393

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Oct 12, 2021

Tested locally with

archery docker run -e SETUPTOOLS_SCM_PRETEND_VERSION="6.0.0.dev444" -e CMAKE_ARGS=-DCMAKE_CXX_STANDARD=17 ubuntu-cpp

and

archery docker run -e SETUPTOOLS_SCM_PRETEND_VERSION="6.0.0.dev444" -e CMAKE_ARGS=-DCMAKE_CXX_STANDARD=11 ubuntu-cpp

and

archery docker run -e SETUPTOOLS_SCM_PRETEND_VERSION="6.0.0.dev444"  ubuntu-cpp

@github-actions
Copy link

@pitrou
Copy link
Member

pitrou commented Oct 12, 2021

@github-actions crossbow submit -g cpp

@github-actions
Copy link

Revision: cd105f5

Submitted crossbow builds: ursacomputing/crossbow @ actions-920

Task Status
test-conda-cpp Github Actions
test-conda-cpp-valgrind Azure
test-debian-11-cpp Github Actions
test-fedora-33-cpp Github Actions
test-ubuntu-18.04-cpp Github Actions
test-ubuntu-18.04-cpp-release Github Actions
test-ubuntu-18.04-cpp-static Github Actions
test-ubuntu-20.04-cpp Github Actions
test-ubuntu-20.04-cpp-14 Github Actions
test-ubuntu-20.04-cpp-17 Github Actions
test-ubuntu-20.04-cpp-thread-sanitizer Github Actions

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Failures are unrelated.

@kou kou closed this in 7bc63c0 Oct 12, 2021
@ursabot
Copy link

ursabot commented Oct 12, 2021

Benchmark runs are scheduled for baseline = 0fbd5e4 and contender = 7bc63c0. 7bc63c0 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.68% ⬆️0.0%] ursa-i9-9960x
[Failed ⬇️0.0% ⬆️0.0%] ursa-thinkcentre-m75q
Supported benchmarks:
ursa-i9-9960x: langs = Python, R, JavaScript
ursa-thinkcentre-m75q: langs = C++, Java
ec2-t3-xlarge-us-east-2: cloud = True

@coryan coryan deleted the ARROW-14301-use-consistent-cmake-cxx-standard-version branch October 12, 2021 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants