New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-14169: [R] altrep for factors #11402
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This currently only deals with a single chunk so that we don't need to be concerned about unification as in |
romainfrancois
force-pushed
the
ARROW-14169_factors
branch
5 times, most recently
from
October 27, 2021 05:07
90c236f
to
84da822
Compare
romainfrancois
force-pushed
the
ARROW-14169_factors
branch
from
November 10, 2021 10:42
84da822
to
acd49b4
Compare
…ys of any number of chunks.
…trep managed fields
…Array because of the way the altrep class work (it retains a chunked array)
reorganise Base to abstract representation, because Factor class will need more things in data2 when the chunks need to be unified
romainfrancois
force-pushed
the
ARROW-14169_factors
branch
from
November 18, 2021 12:43
acd49b4
to
b2d8fea
Compare
This probably needs rebasing now? |
I cherry picked the relevant commit in #11738 |
vibhatha
pushed a commit
to vibhatha/arrow
that referenced
this pull request
Feb 4, 2022
replaces apache#11402 Closes apache#11738 from romainfrancois/ARROW_14169_factors_2 Lead-authored-by: Romain Francois <romain@rstudio.com> Co-authored-by: Jonathan Keane <jkeane@gmail.com> Signed-off-by: Jonathan Keane <jkeane@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
draft pull request, on top of #11369
encouraging:
Created on 2021-10-13 by the reprex package (v2.0.1.9000)