Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-14361: [C++] Add default simd level #11456

Closed
wants to merge 1 commit into from

Conversation

cyb70289
Copy link
Contributor

No description provided.

@github-actions
Copy link

@cyb70289 cyb70289 marked this pull request as ready for review October 19, 2021 06:18
@cyb70289
Copy link
Contributor Author

@github-actions crossbow submit wheel-macos--arm64 wheel-macos--universal2

@github-actions
Copy link

Revision: 9e51f11

Submitted crossbow builds: ursacomputing/crossbow @ actions-1001

Task Status
wheel-macos-big-sur-cp310-arm64 Github Actions
wheel-macos-big-sur-cp310-universal2 Github Actions
wheel-macos-big-sur-cp38-arm64 Github Actions
wheel-macos-big-sur-cp39-arm64 Github Actions
wheel-macos-big-sur-cp39-universal2 Github Actions

@apache apache deleted a comment from github-actions bot Oct 19, 2021
@cyb70289
Copy link
Contributor Author

ASAN test failure is tracked at https://issues.apache.org/jira/browse/ARROW-14370

Comment on lines +106 to +110
if(NOT DEFINED ARROW_SIMD_LEVEL)
set(ARROW_SIMD_LEVEL
"DEFAULT"
CACHE STRING "Compile time SIMD optimization level")
endif()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ARROW_SIMD_LEVEL variable is empty if we don't set it here explicitly, same as passing -DARROW_SIMD_LEVEL=. It disables simd silently when building cpp files under python dir.

Copy link
Member

@kszucs kszucs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks @cyb70289!

@kszucs kszucs closed this in e0b19d9 Oct 19, 2021
@ursabot
Copy link

ursabot commented Oct 19, 2021

Benchmark runs are scheduled for baseline = c02ac38 and contender = e0b19d9. e0b19d9 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.22% ⬆️0.04%] ursa-thinkcentre-m75q
Supported benchmarks:
ursa-i9-9960x: langs = Python, R, JavaScript
ursa-thinkcentre-m75q: langs = C++, Java
ec2-t3-xlarge-us-east-2: cloud = True

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants