ARROW-1624: [C++] Fix build on LLVM 4.0, remove some clang warning suppressions #1148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I2569fe4b574c7e970aeb2b81b7e2c96ca3c6cfd4
Change-Id: Id1a9ec85ea14be74d8451af5975209aa80029056
Change-Id: I38e0c03c37eb7e922e07526754a1062a10f3ebc7
Change-Id: Ie1f126f2d9ad83feafe5ec19e32e10a2cf404d12
Change-Id: I942ece689faf641ca9988984f283e6660d9d896a
wesm
changed the title
Change-Id: I66087983cf5c08a8b3cc9bcd9e688ceb1762a48d
|
OK, I removed as many warning suppressions as I could. Thanks again @renesugar for setting this up! @pcmoritz or @cpcloud would you mind taking a look through these? Should be mostly straightforward. Clang can also check that our doxygen comments are well formed, so... 🤘 |
Change-Id: Iad7382b5817c4fa1d3a50fe9415f101baba322ac
Change-Id: I07ef8ce45a3172fdfddff2049353a1f5c5e37a62
…arrow Change-Id: I93484e74182c72a7fe6f7cab44b07597f1c22f3e
Change-Id: Icd2379a94062b51aeed5a137ce240ce30e0b7bd9
|
+1, this is all pretty straightforward. If any comments I will be happy to address in a follow up patch |
wesm
added a commit
to wesm/arrow
that referenced
this pull request
Oct 3, 2017
…ppressions I'm going to quick make a pass through later today and see how many of these warning suppressions I can remove Author: Wes McKinney <wes.mckinney@twosigma.com> Closes apache#1148 from wesm/warning-fixes and squashes the following commits: e930152 [Wes McKinney] Only build compute modules if -DARROW_COMPUTE=ON d6ca7ac [Wes McKinney] Slight refactor of CMakeLists.txt to move Arrow library setup to src/arrow e2c61a2 [Wes McKinney] Use -Wno-unknown-warning-option 3d2d726 [Wes McKinney] Fix travis CI script 6d0d411 [Wes McKinney] Use BUILD_WARNING_LEVEL in Travis CI 1bec4a7 [Wes McKinney] Fix some more compiler warnings cae05fb [Wes McKinney] Fix documentation compiler warnings f76b2b9 [Wes McKinney] Fix a bunch of documentation warnings ac54e2d [Wes McKinney] Remove some clang warning suppressions, fix warnings 6935b8c [Wes McKinney] Fix compiler warnings with clang-4.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm going to quick make a pass through later today and see how many of these warning suppressions I can remove