Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-14581: [C++] Fine-grained IPC reader tests are flaky #11600

Conversation

westonpace
Copy link
Member

The footer contains a copy of the schema. The schema only specifies endianess if the machine is big-endian. So the footer size differs based on the endianess of the test machine.

… buffer instead of hard-coding the size of the schema depends on whether endianess needs to be specified or not.
@github-actions
Copy link

github-actions bot commented Nov 3, 2021

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW

Opening JIRAs ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename pull request title in the following format?

ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

See also:

@kou kou changed the title [C++] FIne-grained IPC reader tests are flaky [C++] Fine-grained IPC reader tests are flaky Nov 4, 2021
@westonpace westonpace changed the title [C++] Fine-grained IPC reader tests are flaky ARROW-14581: [C++] Fine-grained IPC reader tests are flaky Nov 4, 2021
@github-actions
Copy link

github-actions bot commented Nov 4, 2021

@github-actions
Copy link

github-actions bot commented Nov 4, 2021

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

Copy link
Member

@lidavidm lidavidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this.

I'm not sure what's up with the integration tests in CI. It doesn't look related to this.

@lidavidm lidavidm closed this in 55a8b78 Nov 4, 2021
@ursabot
Copy link

ursabot commented Nov 4, 2021

Benchmark runs are scheduled for baseline = 48009fb and contender = 55a8b78. 55a8b78 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.22% ⬆️0.0%] ursa-thinkcentre-m75q
Supported benchmarks:
ursa-i9-9960x: langs = Python, R, JavaScript
ursa-thinkcentre-m75q: langs = C++, Java
ec2-t3-xlarge-us-east-2: cloud = True

@westonpace westonpace deleted the bugfix/ARROW-14581--partial-ipc-io-test-flaky branch January 6, 2022 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants