ARROW-13888: [R] Rephrase docs for schema()'s ellipses argument and rephrase error message #11645
Conversation
|
|
r/R/schema.R
Outdated
|
|
||
| schema_check <- function(items) { | ||
| all(map_lgl(.list, ~ inherits(.x, "Field"))) || FALSE | ||
| } |
There was a problem hiding this comment.
Is schema_check used elsewhere? I don't see it but I might be missing something?
There was a problem hiding this comment.
Oops, intended to use it and then didn't, will update
There was a problem hiding this comment.
It might be helpful as a helper especially if we accept a list as input (or for testing). But up to you if you think it's better as a helper or inline
There was a problem hiding this comment.
Had to refactor now so dropped it as it no longer works
r/R/schema.R
Outdated
| @@ -157,6 +165,9 @@ Schema$create <- function(...) { | |||
| .list <- list2(...) | |||
| if (all(map_lgl(.list, ~ inherits(., "Field")))) { | |||
| schema_(.list) | |||
| } else if (is.null(names(.list))) { | |||
| # If not supplied as fields, only other alternative is e.g.`a = int16()` | |||
| abort("Schema definitions must be supplied as field/data type or field name/data type pairs") | |||
| } else { | |||
| schema_(.fields(.list)) | |||
| } | |||
There was a problem hiding this comment.
Would it be possible (and if so wise?) to check if length(.list) == 1 && schema_check(.list[[1]]) then schema_(.fields(.list[[1]]))?
One could always call do.call(schema, list), but it might be nice to also accept a single list containing the specifications too?
There was a problem hiding this comment.
Sure, though would we want to also expand it to check if length(.list) == 1 && all(map_lgl(.list, ~ inherits(.x, "DataType"))) and allow that too?
There was a problem hiding this comment.
(i.e. so the user can supply a list of name/value pairs and it's not important which of the 2 methods they use to specify the name - fields or just field names)
There was a problem hiding this comment.
OH, yes absolutely (if it's not too much scope creep here!) that would be quite nice
| ) | ||
|
|
||
| expect_equal(name_list_schema, schema(b = double(), c = string(), d = int8())) | ||
| expect_equal(field_list_schema, schema(b = double(), c = bool(), d = string())) |
Co-authored-by: Jonathan Keane <jkeane@gmail.com>
|
Benchmark runs are scheduled for baseline = 225d954 and contender = a374604. a374604 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
No description provided.