Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-14662: [Docs] Add note about linking Flight/gRPC/Protobuf #11698

Closed
wants to merge 3 commits into from

Conversation

lidavidm
Copy link
Member

Adds a note about linking Flight/gRPC/Protobuf as a reference for issues like those seen in #11657.

Also fixes a number of build warnings.

@lidavidm
Copy link
Member Author

Rendered:
image

@github-actions
Copy link

@github-actions
Copy link

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

Copy link
Contributor

@cyb70289 cyb70289 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

linked, and the same goes for dynamic linking.
* Some platforms (e.g. Ubuntu 20.04 at the time of this writing) may ship a
version of Protobuf and/or gRPC that is not recent enough for Arrow
Flight. In that case, Arrow Flight bundles these dependencies, so case must
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: "care"

@cyb70289 cyb70289 closed this in c038e61 Nov 18, 2021
@ursabot
Copy link

ursabot commented Nov 18, 2021

Benchmark runs are scheduled for baseline = 2fec2fa and contender = c038e61. c038e61 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.51% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.4% ⬆️0.27%] ursa-thinkcentre-m75q
Supported benchmarks:
ursa-i9-9960x: langs = Python, R, JavaScript
ursa-thinkcentre-m75q: langs = C++, Java
ec2-t3-xlarge-us-east-2: cloud = True

@lidavidm lidavidm deleted the arrow-14662 branch November 18, 2021 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants