ARROW-14739: [JS] Ensure docs point to right source #11728
Conversation
|
|
ci/scripts/js_build.sh
Outdated
| elif [ $(git config --get remote.upstream.url) == "https://github.com/apache/arrow.git" ]; then | ||
| yarn doc --gitRemote upstream |
There was a problem hiding this comment.
Could you also add apache case?
elif [ $(git config --get remote.apache.url) == "https://github.com/apache/arrow.git" ]; then
yarn doc --gitRemote apacheWe're using apache in our release document: https://cwiki.apache.org/confluence/display/ARROW/Release+Management+Guide
There was a problem hiding this comment.
Will do. https://arrow.apache.org/docs/developers/contributing.html says to use upstream btw.
The apache remote should be git@github.com:apache/arrow.git, right?
|
@github-actions crossbow submit test-ubuntu-default-docs |
|
Revision: 192f828 Submitted crossbow builds: ursacomputing/crossbow @ actions-1161
|
|
@github-actions crossbow submit test-ubuntu-default-docs |
|
Revision: f2905f6 Submitted crossbow builds: ursacomputing/crossbow @ actions-1162
|
|
@kuo @kszucs, it looks like the remote in the CI isn't set as described in https://cwiki.apache.org/confluence/display/ARROW/Release+Management+Guide. Can you help with that?
|
|
Could you try this? diff --git a/dev/tasks/docker-tests/azure.linux.yml b/dev/tasks/docker-tests/azure.linux.yml
index b8f1151f7..dfa07a0d5 100644
--- a/dev/tasks/docker-tests/azure.linux.yml
+++ b/dev/tasks/docker-tests/azure.linux.yml
@@ -43,6 +43,7 @@ jobs:
git -C arrow fetch -t {{ arrow.remote }} {{ arrow.branch }}
git -C arrow checkout FETCH_HEAD
git -C arrow submodule update --init --recursive
+ git -C arrow remote add upstream https://github.com/apache/arrow.git
displayName: Clone arrow
- script: pip install -e arrow/dev/archery[docker] |
|
@github-actions crossbow submit test-ubuntu-default-docs |
|
Revision: d71bc65 Submitted crossbow builds: ursacomputing/crossbow @ actions-1163
|
domoritz
changed the title
|
Benchmark runs are scheduled for baseline = de5aa54 and contender = a25aa8d. a25aa8d is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
No description provided.