Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-14788: [C++] Fix warning in dataset/file_orc_test.cc #11750

Closed
wants to merge 1 commit into from

Conversation

iajoiner
Copy link

@iajoiner iajoiner commented Nov 22, 2021

This is a very minor issue that is likely to have blocked our tests in master for a while. I do wonder why it was only discovered last night though. Is it because we are not testing ORC-related code by default?

@github-actions
Copy link

@github-actions
Copy link

⚠️ Ticket has no components in JIRA, make sure you assign one.

@github-actions
Copy link

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

@iajoiner iajoiner changed the title ARROW-14788: Fix warning in dataset/file_orc_test.cc ARROW-14788: [C++] Fix warning in dataset/file_orc_test.cc Nov 22, 2021
Copy link
Member

@lidavidm lidavidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this.

We weren't enabling the relevant warning on GCC (see #11747) so I suppose it wasn't being built on MacOS (where we do enable the warning on Clang) until recently.

@lidavidm lidavidm closed this in 92ee295 Nov 22, 2021
@ursabot
Copy link

ursabot commented Nov 22, 2021

Benchmark runs are scheduled for baseline = 9c935d4 and contender = 92ee295. 92ee295 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.18% ⬆️0.0%] ursa-thinkcentre-m75q
Supported benchmarks:
ursa-i9-9960x: langs = Python, R, JavaScript
ursa-thinkcentre-m75q: langs = C++, Java
ec2-t3-xlarge-us-east-2: cloud = True

@iajoiner iajoiner deleted the ARROW-14788 branch November 23, 2021 04:41
@iajoiner iajoiner restored the ARROW-14788 branch November 23, 2021 04:41
@iajoiner iajoiner deleted the ARROW-14788 branch November 23, 2021 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants