ARROW-14842: [C++] Improve precision range error messages for Decimal #11773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyb70289
commented
Nov 25, 2021
cpp/src/arrow/type.cc
Outdated
Comment on lines
834
to
836
| const auto min = kMinPrecision, max = kMaxPrecision; | ||
| return Status::Invalid("Decimal precision out of range [", min, ", ", max, | ||
| "]: ", precision); |
There was a problem hiding this comment.
It's mysterious why direct referencing kMinPrecision in Status::Invalid function leads to "undefined symbol" link error.
Maybe related to constexpr?
There was a problem hiding this comment.
It looks like we forgot to declare the constexpr in the .cc file. This compiles and links for me:
diff --git a/cpp/src/arrow/type.cc b/cpp/src/arrow/type.cc
index 7b761b3a6..fb872725f 100644
--- a/cpp/src/arrow/type.cc
+++ b/cpp/src/arrow/type.cc
@@ -823,6 +823,10 @@ int32_t DecimalType::DecimalSize(int32_t precision) {
// ----------------------------------------------------------------------
// Decimal128 type
+constexpr int32_t Decimal128Type::kMinPrecision;
+constexpr int32_t Decimal128Type::kMaxPrecision;
+constexpr int32_t Decimal128Type::kByteWidth;
+
Decimal128Type::Decimal128Type(int32_t precision, int32_t scale)
: DecimalType(type_id, 16, precision, scale) {
ARROW_CHECK_GE(precision, kMinPrecision);
@@ -831,9 +835,8 @@ Decimal128Type::Decimal128Type(int32_t precision, int32_t scale)
Result<std::shared_ptr<DataType>> Decimal128Type::Make(int32_t precision, int32_t scale) {
if (precision < kMinPrecision || precision > kMaxPrecision) {
- const auto min = kMinPrecision, max = kMaxPrecision;
- return Status::Invalid("Decimal precision out of range [", min, ", ", max,
- "]: ", precision);
+ return Status::Invalid("Decimal precision out of range [", kMinPrecision, ", ",
+ kMaxPrecision, "]: ", precision);
}
return std::make_shared<Decimal128Type>(precision, scale);
}
@@ -841,6 +844,10 @@ Result<std::shared_ptr<DataType>> Decimal128Type::Make(int32_t precision, int32_
// ----------------------------------------------------------------------
// Decimal256 type
+constexpr int32_t Decimal256Type::kMinPrecision;
+constexpr int32_t Decimal256Type::kMaxPrecision;
+constexpr int32_t Decimal256Type::kByteWidth;
+
Decimal256Type::Decimal256Type(int32_t precision, int32_t scale)
: DecimalType(type_id, 32, precision, scale) {
ARROW_CHECK_GE(precision, kMinPrecision);
@@ -849,9 +856,8 @@ Decimal256Type::Decimal256Type(int32_t precision, int32_t scale)
Result<std::shared_ptr<DataType>> Decimal256Type::Make(int32_t precision, int32_t scale) {
if (precision < kMinPrecision || precision > kMaxPrecision) {
- const auto min = kMinPrecision, max = kMaxPrecision;
- return Status::Invalid("Decimal precision out of range [", min, ", ", max,
- "]: ", precision);
+ return Status::Invalid("Decimal precision out of range [", kMinPrecision, ", ",
+ kMaxPrecision, "]: ", precision);
}
return std::make_shared<Decimal256Type>(precision, scale);
}There was a problem hiding this comment.
This issue should have been fixed in C++17.
The workaround in http://ostack.cn/?qa=744640/ looks simpler.
Original post: https://stackoverflow.com/questions/40690260/undefined-reference-error-for-static-constexpr-member
|
@nealrichardson , looks the RTools 35 job timed out |
lidavidm
approved these changes
Nov 29, 2021
cpp/src/arrow/type.cc
Outdated
Comment on lines
834
to
836
| const auto min = kMinPrecision, max = kMaxPrecision; | ||
| return Status::Invalid("Decimal precision out of range [", min, ", ", max, | ||
| "]: ", precision); |
There was a problem hiding this comment.
It looks like we forgot to declare the constexpr in the .cc file. This compiles and links for me:
diff --git a/cpp/src/arrow/type.cc b/cpp/src/arrow/type.cc
index 7b761b3a6..fb872725f 100644
--- a/cpp/src/arrow/type.cc
+++ b/cpp/src/arrow/type.cc
@@ -823,6 +823,10 @@ int32_t DecimalType::DecimalSize(int32_t precision) {
// ----------------------------------------------------------------------
// Decimal128 type
+constexpr int32_t Decimal128Type::kMinPrecision;
+constexpr int32_t Decimal128Type::kMaxPrecision;
+constexpr int32_t Decimal128Type::kByteWidth;
+
Decimal128Type::Decimal128Type(int32_t precision, int32_t scale)
: DecimalType(type_id, 16, precision, scale) {
ARROW_CHECK_GE(precision, kMinPrecision);
@@ -831,9 +835,8 @@ Decimal128Type::Decimal128Type(int32_t precision, int32_t scale)
Result<std::shared_ptr<DataType>> Decimal128Type::Make(int32_t precision, int32_t scale) {
if (precision < kMinPrecision || precision > kMaxPrecision) {
- const auto min = kMinPrecision, max = kMaxPrecision;
- return Status::Invalid("Decimal precision out of range [", min, ", ", max,
- "]: ", precision);
+ return Status::Invalid("Decimal precision out of range [", kMinPrecision, ", ",
+ kMaxPrecision, "]: ", precision);
}
return std::make_shared<Decimal128Type>(precision, scale);
}
@@ -841,6 +844,10 @@ Result<std::shared_ptr<DataType>> Decimal128Type::Make(int32_t precision, int32_
// ----------------------------------------------------------------------
// Decimal256 type
+constexpr int32_t Decimal256Type::kMinPrecision;
+constexpr int32_t Decimal256Type::kMaxPrecision;
+constexpr int32_t Decimal256Type::kByteWidth;
+
Decimal256Type::Decimal256Type(int32_t precision, int32_t scale)
: DecimalType(type_id, 32, precision, scale) {
ARROW_CHECK_GE(precision, kMinPrecision);
@@ -849,9 +856,8 @@ Decimal256Type::Decimal256Type(int32_t precision, int32_t scale)
Result<std::shared_ptr<DataType>> Decimal256Type::Make(int32_t precision, int32_t scale) {
if (precision < kMinPrecision || precision > kMaxPrecision) {
- const auto min = kMinPrecision, max = kMaxPrecision;
- return Status::Invalid("Decimal precision out of range [", min, ", ", max,
- "]: ", precision);
+ return Status::Invalid("Decimal precision out of range [", kMinPrecision, ", ",
+ kMaxPrecision, "]: ", precision);
}
return std::make_shared<Decimal256Type>(precision, scale);
}
I'm not sure why that would be, but it seems to have happened again. |
Decimal128: "Invalid: Decimal precision out of range [1, 38]: 0" Decimal256: "Invalid: Decimal precision out of range [1, 76]: 100"
cyb70289
force-pushed
the
14842-decimal-error-msg
branch
from
eaab6ce
to
b83b6ab
Compare
|
Benchmark runs are scheduled for baseline = debf48d and contender = 29f98dd. 29f98dd is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
kou
pushed a commit
to kou/arrow
that referenced
this pull request
Dec 1, 2021
Decimal128: `Invalid: Decimal precision out of range [1, 38]: 0` Decimal256: `Invalid: Decimal precision out of range [1, 76]: 100` Closes apache#11773 from cyb70289/14842-decimal-error-msg Authored-by: Yibo Cai <yibo.cai@arm.com> Signed-off-by: Yibo Cai <yibo.cai@arm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decimal128:
Invalid: Decimal precision out of range [1, 38]: 0Decimal256:
Invalid: Decimal precision out of range [1, 76]: 100