New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-14715: [Doc] Steps in making your first PR - finding issues #11807
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some nits. I'll defer to @thisisnic otherwise.
@@ -78,6 +78,9 @@ assign yourself an issue, you will need "Contributor" permissions on the | |||
Apache Arrow JIRA. To get this role, ask on the mailing list for a project | |||
maintainer's help. | |||
|
|||
|
|||
.. _jira-tips: | |||
|
|||
Tips for using JIRA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should there be a "Creating a JIRA account" section just before this? You could move the text you've already written in "Finding good first issues" there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure I understood completely. Will rearrange the text and see if that's what u meant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two paragraphs above already has a short explanation of needing to sign up to JIRA
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good; just a few suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just one comment about the exact url link
@@ -78,6 +78,9 @@ assign yourself an issue, you will need "Contributor" permissions on the | |||
Apache Arrow JIRA. To get this role, ask on the mailing list for a project | |||
maintainer's help. | |||
|
|||
|
|||
.. _jira-tips: | |||
|
|||
Tips for using JIRA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two paragraphs above already has a short explanation of needing to sign up to JIRA
Thanks Joris, I forgot to correct the link! |
Co-authored-by: Nic Crane <thisisnic@gmail.com>
Yes, sounds good! |
Benchmark runs are scheduled for baseline = 065b1fc and contender = 8d6a897. 8d6a897 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Added the Finding good first issue section of the Guide.