Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-14715: [Doc] Steps in making your first PR - finding issues #11807

Closed
wants to merge 6 commits into from

Conversation

AlenkaF
Copy link
Member

@AlenkaF AlenkaF commented Nov 30, 2021

Added the Finding good first issue section of the Guide.

@github-actions
Copy link

Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nits. I'll defer to @thisisnic otherwise.

@@ -78,6 +78,9 @@ assign yourself an issue, you will need "Contributor" permissions on the
Apache Arrow JIRA. To get this role, ask on the mailing list for a project
maintainer's help.


.. _jira-tips:

Tips for using JIRA
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be a "Creating a JIRA account" section just before this? You could move the text you've already written in "Finding good first issues" there.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I understood completely. Will rearrange the text and see if that's what u meant.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two paragraphs above already has a short explanation of needing to sign up to JIRA

Copy link
Member

@thisisnic thisisnic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good; just a few suggestions.

Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just one comment about the exact url link

@@ -78,6 +78,9 @@ assign yourself an issue, you will need "Contributor" permissions on the
Apache Arrow JIRA. To get this role, ask on the mailing list for a project
maintainer's help.


.. _jira-tips:

Tips for using JIRA
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two paragraphs above already has a short explanation of needing to sign up to JIRA

@AlenkaF
Copy link
Member Author

AlenkaF commented Dec 8, 2021

Thanks Joris, I forgot to correct the link!
As for the JIRA sign in, I know. I am thinking of keeping it like this for now and change when we decide what do to with the contributing page. What do you think?

@jorisvandenbossche
Copy link
Member

As for the JIRA sign in, I know. I am thinking of keeping it like this for now and change when we decide what do to with the contributing page. What do you think?

Yes, sounds good!

@thisisnic thisisnic closed this in 8d6a897 Dec 8, 2021
@ursabot
Copy link

ursabot commented Dec 8, 2021

Benchmark runs are scheduled for baseline = 065b1fc and contender = 8d6a897. 8d6a897 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.74% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.09% ⬆️0.13%] ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@AlenkaF AlenkaF deleted the ARROW-14715 branch December 8, 2021 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants