Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-14935: [GLib] Add GArrowTemporalDataType #11809

Closed

Conversation

okadakk
Copy link
Contributor

@okadakk okadakk commented Nov 30, 2021

This PR adds temporal data type.

@github-actions
Copy link

@github-actions
Copy link

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

@kou
Copy link
Member

kou commented Nov 30, 2021

Could you open a new sub-task of ARROW-13808 instead of associating this pull request to ARROW-13808?
Because this pull request doesn't cover all features described in ARROW-13808.

@okadakk okadakk changed the title ARROW-13808: [GLib]Add Temporal Data Type ARROW-14935: [GLib]Add Temporal Data Type Dec 1, 2021
@github-actions
Copy link

github-actions bot commented Dec 1, 2021

@okadakk okadakk changed the title ARROW-14935: [GLib]Add Temporal Data Type ARROW-14935: [Ruby]Add Temporal Data Type Dec 1, 2021
@okadakk
Copy link
Contributor Author

okadakk commented Dec 1, 2021

@kou
Thanks!
I modified it!

@kou kou changed the title ARROW-14935: [Ruby]Add Temporal Data Type ARROW-14935: [Ruby] Add GArrowTemporalDataType Dec 1, 2021
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

c_glib/arrow-glib/basic-data-type.cpp Outdated Show resolved Hide resolved
@kou kou changed the title ARROW-14935: [Ruby] Add GArrowTemporalDataType ARROW-14935: [GLib] Add GArrowTemporalDataType Dec 1, 2021
@kou kou closed this in 6525cf5 Dec 1, 2021
@ursabot
Copy link

ursabot commented Dec 1, 2021

Benchmark runs are scheduled for baseline = ad07130 and contender = 6525cf5. 6525cf5 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.04% ⬆️0.0%] ursa-thinkcentre-m75q
Supported benchmarks:
ursa-i9-9960x: langs = Python, R, JavaScript
ursa-thinkcentre-m75q: langs = C++, Java
ec2-t3-xlarge-us-east-2: cloud = True

kou added a commit to kou/arrow that referenced this pull request Dec 1, 2021
This PR adds temporal data type.

Closes apache#11809 from okadakk/arrow-glib-add-temporal-data-type

Lead-authored-by: okadakk <k.suke.jp1990@gmail.com>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants