-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-14932: [CI] Prefer mamba over conda #11816
Conversation
|
@github-actions crossbow submit test-conda-* |
Revision: ad41c19 Submitted crossbow builds: ursacomputing/crossbow @ actions-1220 |
Perhaps you can also make the same changes for AppVeyor? |
@@ -29,8 +29,7 @@ dask=$1 | |||
if [ "${dask}" = "master" ]; then | |||
pip install https://github.com/dask/dask/archive/main.tar.gz#egg=dask[dataframe] | |||
elif [ "${dask}" = "latest" ]; then | |||
conda install -q dask | |||
pip install dask |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the reason to switch to pip
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These scripts might be used from non-conda images so rather prefer pip here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This broke the nightly integration build, because the pip version not installing pandas automatically (now this is easily solved with pip install dask[dataframe]
like is already done above for the main branch)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, creating a PR for it.
@github-actions crossbow submit test-conda-* |
Revision: b709bd7 Submitted crossbow builds: ursacomputing/crossbow @ actions-1225 |
@github-actions crossbow submit test-conda-* |
Revision: bff9147 Submitted crossbow builds: ursacomputing/crossbow @ actions-1226 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, merging on green
Benchmark runs are scheduled for baseline = bca0681 and contender = f416111. f416111 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Mamba should provide quicker image builds compared to conda.