Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-14969: [C++][Python] Un-deprecate FileSystem::OpenAppendStream #11845

Closed
wants to merge 2 commits into from

Conversation

Jedi18
Copy link
Contributor

@Jedi18 Jedi18 commented Dec 3, 2021

Un-deprecating FileSystem::OpenAppendStream in C++ and Python. It will remain unimplemented for filesystems which don't support it.

@github-actions
Copy link

github-actions bot commented Dec 3, 2021

@github-actions
Copy link

github-actions bot commented Dec 3, 2021

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

@Jedi18 Jedi18 force-pushed the undeprecate_fs_openappendstream branch from 59e51fa to d72dd8c Compare December 3, 2021 14:05
@Jedi18 Jedi18 requested a review from pitrou December 3, 2021 14:06
Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Jedi18 . Will tweak the docstring a bit but +1 otherwise.

@pitrou pitrou closed this in 18b4991 Dec 6, 2021
@ursabot
Copy link

ursabot commented Dec 6, 2021

Benchmark runs are scheduled for baseline = ad1fd04 and contender = 18b4991. 18b4991 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.13% ⬆️0.0%] ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@Jorricks
Copy link

Jorricks commented Sep 9, 2022

Thanks for un-deprecating this 👍. We really need this functionality for HDFS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants