Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-14975: [Docs] Fix typo in emit_dictionary_deltas documentation #11848

Closed
wants to merge 3 commits into from
Closed

ARROW-14975: [Docs] Fix typo in emit_dictionary_deltas documentation #11848

wants to merge 3 commits into from

Conversation

zixi-bwang
Copy link
Contributor

Typo in \arrow\cpp\src\arrow\ipc\options.h, in my understanding, it should be emitted, not omitted.

@github-actions
Copy link

github-actions bot commented Dec 3, 2021

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW

Opening JIRAs ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename pull request title in the following format?

ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

See also:

@zixi-bwang zixi-bwang changed the title Fix typo: Omitted -> Emitted in emit_dictionary_deltas documentation ARROW-14975: [Doc][C++] Fix typo: Omitted -> Emitted in emit_dictionary_deltas documentation Dec 3, 2021
@github-actions
Copy link

github-actions bot commented Dec 3, 2021

@github-actions
Copy link

github-actions bot commented Dec 3, 2021

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

@zixi-bwang zixi-bwang changed the title ARROW-14975: [Doc][C++] Fix typo: Omitted -> Emitted in emit_dictionary_deltas documentation ARROW-14975: [Doc][C++] Fix typo in emit_dictionary_deltas documentation Dec 3, 2021
@zixi-bwang zixi-bwang changed the title ARROW-14975: [Doc][C++] Fix typo in emit_dictionary_deltas documentation ARROW-14975: [Docs] Fix typo in emit_dictionary_deltas documentation Dec 3, 2021
@pitrou
Copy link
Member

pitrou commented Dec 14, 2021

Typo in \arrow\cpp\src\arrow\ipc\options.h, in my understanding, it should be emitted, not omitted.

Indeed!

@pitrou pitrou closed this in e63ba1c Dec 14, 2021
@ursabot
Copy link

ursabot commented Dec 14, 2021

Benchmark runs are scheduled for baseline = 5d44cb8 and contender = e63ba1c. e63ba1c is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.45% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.44% ⬆️0.18%] ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants