Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-14971: [C++] Implement GcsFileSystem::Move #11891

Closed
wants to merge 1 commit into from
Closed

ARROW-14971: [C++] Implement GcsFileSystem::Move #11891

wants to merge 1 commit into from

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Dec 7, 2021

No description provided.

@github-actions
Copy link

github-actions bot commented Dec 7, 2021

https://issues.apache.org/jira/browse/ARROW-14971

@github-actions
Copy link

github-actions bot commented Dec 7, 2021

⚠️ Ticket has no components in JIRA, make sure you assign one.

@coryan coryan marked this pull request as ready for review December 7, 2021 22:42
@pitrou pitrou changed the title ARROW-14971: [C++] implement GcsFileSystem::Move ARROW-14971: [C++] Implement GcsFileSystem::Move Dec 8, 2021
pitrou
pitrou approved these changes Dec 8, 2021
View reviewed changes
Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@pitrou pitrou closed this in 6896c6e Dec 8, 2021
@ursabot
Copy link

ursabot commented Dec 8, 2021 •
edited

Benchmark runs are scheduled for baseline = 4cdb149 and contender = 6896c6e. 6896c6e is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.13% ⬆️0.0%] ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@coryan coryan deleted the ARROW-14971-gcsfs-move branch December 8, 2021 14:32
@asfimport asfimport mentioned this pull request Dec 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pitrou pitrou pitrou approved these changes

Assignees
No one assigned
Labels
Component: C++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@coryan @ursabot @pitrou