Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-14849: [R] Update messaging in installation scripts #11901

Closed

Conversation

thisisnic
Copy link
Member

No description provided.

@github-actions
Copy link

github-actions bot commented Dec 8, 2021

@thisisnic
Copy link
Member Author

Build failure due to an inability to download cmake, rather than related to this PR

Copy link
Member

@jonkeane jonkeane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, one comment about what env var we want to advertise.

cat("*** Building libarrow\n")
cat("*** For a faster installation, set the environment variable LIBARROW_BINARY=true before installing\n")
cat("*** Not all features are enabled by default.")
cat(" For a fully-featured installation, set the environment variable LIBARROW_MINIMAL=false before installing\n")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we instead want to offer NOT_CRAN=true for both of these (and possibly collapse it down to "for a fester, more complete installation, set the environment variable NOT_CRAN=TRUE before installing")?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I was wanting to be more explicit about the multiple things which were going on, but I think we can get the best of both worlds by referring to NOT_CRAN and then suggesting the user takes a look at the install vignette for more info, like we do in another place in the script.

@thisisnic thisisnic closed this in 3f6773a Dec 9, 2021
@ursabot
Copy link

ursabot commented Dec 9, 2021

Benchmark runs are scheduled for baseline = 53ab5a0 and contender = 3f6773a. 3f6773a is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.31% ⬆️0.04%] ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants