Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-13401 [R]: Update python.Rmd vignette #11914

Closed
wants to merge 9 commits into from

Conversation

AlenkaF
Copy link
Member

@AlenkaF AlenkaF commented Dec 9, 2021

No description provided.

@github-actions
Copy link

github-actions bot commented Dec 9, 2021

Copy link
Member

@thisisnic thisisnic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good! Most of the changes I've suggested are stylistic things we updated across the other R documentation which I forgot to mention in this ticket. Your explanations of things here look great - thanks for adding in those bits!

r/vignettes/python.Rmd Outdated Show resolved Hide resolved
r/vignettes/python.Rmd Show resolved Hide resolved
r/vignettes/python.Rmd Outdated Show resolved Hide resolved
r/vignettes/python.Rmd Outdated Show resolved Hide resolved
r/vignettes/python.Rmd Outdated Show resolved Hide resolved
r/vignettes/python.Rmd Outdated Show resolved Hide resolved
r/vignettes/python.Rmd Outdated Show resolved Hide resolved
r/vignettes/python.Rmd Outdated Show resolved Hide resolved
r/vignettes/python.Rmd Outdated Show resolved Hide resolved
r/vignettes/python.Rmd Outdated Show resolved Hide resolved
Co-authored-by: Nic Crane <thisisnic@gmail.com>
Copy link
Member

@thisisnic thisisnic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny additional change, otherwise it's good to go

r/vignettes/python.Rmd Outdated Show resolved Hide resolved
Co-authored-by: Nic Crane <thisisnic@gmail.com>
@AlenkaF
Copy link
Member Author

AlenkaF commented Dec 9, 2021

Info: committed the changes for this PR completely through the GitHub editor!

@thisisnic
Copy link
Member

Info: committed the changes for this PR completely through the GitHub editor!

Thanks for mentioning! I guess the thing I'd recommend is doing it locally to build the docs to make sure they look OK, but for this PR I'm happy to double check that myself :)

r/vignettes/python.Rmd Outdated Show resolved Hide resolved
Co-authored-by: Nic Crane <thisisnic@gmail.com>
@thisisnic thisisnic closed this in fa5bbb7 Dec 9, 2021
@ursabot
Copy link

ursabot commented Dec 9, 2021

Benchmark runs are scheduled for baseline = b74d8cf and contender = fa5bbb7. fa5bbb7 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.22% ⬆️0.0%] ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@AlenkaF AlenkaF deleted the patch-1 branch December 10, 2021 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants