Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-15119: [C++] allow reading directories as files in generic tests #11962

Closed
wants to merge 1 commit into from
Closed

ARROW-15119: [C++] allow reading directories as files in generic tests #11962

wants to merge 1 commit into from

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Dec 15, 2021

This is motivated by GCS, where checking if an object is a directory marker would add too much overhead.

@github-actions
Copy link

https://issues.apache.org/jira/browse/ARROW-15119

@coryan coryan force-pushed the ARROW-15119-allow-reading-directories-in-generic-tests branch from 780fe06 to 43c76d6 Compare December 16, 2021 15:45
pitrou
pitrou approved these changes Dec 20, 2021
View reviewed changes
Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you very much

@pitrou pitrou closed this in e7c2ead Dec 20, 2021
@ursabot
Copy link

ursabot commented Dec 20, 2021 •
edited

Benchmark runs are scheduled for baseline = 97a8159 and contender = e7c2ead. e7c2ead is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Scheduled] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.22% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/127| e7c2ead8 ec2-t3-xlarge-us-east-2>
[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/115| e7c2ead8 ursa-i9-9960x>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/118| e7c2ead8 ursa-thinkcentre-m75q>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/126| 97a81595 ec2-t3-xlarge-us-east-2>
[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/114| 97a81595 ursa-i9-9960x>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/117| 97a81595 ursa-thinkcentre-m75q>
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@coryan coryan deleted the ARROW-15119-allow-reading-directories-in-generic-tests branch December 20, 2021 14:32
rafael-telles pushed a commit to rafael-telles/arrow that referenced this pull request Dec 20, 2021
@coryan @rafael-telles
ARROW-15119: [C++] allow reading directories as files in generic tests
254c24c 
This is motivated by GCS, where checking if an object is a directory marker would add too much overhead.

Closes apache#11962 from coryan/ARROW-15119-allow-reading-directories-in-generic-tests

Authored-by: Carlos O'Ryan <coryan@google.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
@asfimport asfimport mentioned this pull request Mar 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pitrou pitrou pitrou approved these changes

Assignees
No one assigned
Labels
Component: C++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@coryan @ursabot @pitrou