ARROW-10643: [Python] Pandas<->pyarrow roundtrip failing to recreate index for empty dataframe #12081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edponce
suggested changes
Jan 9, 2022
|
@jorisvandenbossche could you give a final look at this PR please? |
jorisvandenbossche
approved these changes
Jan 18, 2022
|
Benchmark runs are scheduled for baseline = 8254615 and contender = cec5a17. cec5a17 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
kszucs
pushed a commit
that referenced
this pull request
Jan 19, 2022
This is a revert of ARROW-10643 (#12081), but I think the bug fix of that PR is less important than getting this regression fixed (I left the test that was added, but with an xfail) Closes #12189 from jorisvandenbossche/ARROW-15370 Authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com> Signed-off-by: Krisztián Szűcs <szucs.krisztian@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a check to the
_reconstruct_indexinpandas_compat.pyso that the roundtrip is correct for an emptypandas.DataFramewith and index.