Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-15269: [C++][Docs] Clarify that not all compute functions are invocable via CallFunction #12104

Closed
wants to merge 2 commits into from
Closed

ARROW-15269: [C++][Docs] Clarify that not all compute functions are invocable via CallFunction #12104

wants to merge 2 commits into from

Conversation

sanjibansg
Copy link
Contributor

This PR updates the documentation for Compute Functions to clarify that stateful compute functions like Grouped Aggregations are not invocable via CallFunction

@github-actions
Copy link

github-actions bot commented Jan 8, 2022

https://issues.apache.org/jira/browse/ARROW-15269

@github-actions
Copy link

github-actions bot commented Jan 8, 2022

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

lidavidm
lidavidm reviewed Jan 10, 2022
View reviewed changes
Copy link
Member

@lidavidm lidavidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this - just some comments about the wording

docs/source/cpp/compute.rst Outdated Show resolved Hide resolved
@lidavidm lidavidm closed this in 7a0141a Jan 11, 2022
@ursabot
Copy link

ursabot commented Jan 11, 2022 •
edited
Loading

Benchmark runs are scheduled for baseline = d88e232 and contender = 7a0141a. 7a0141a is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed] ursa-i9-9960x
[Finished ⬇️0.13% ⬆️0.0%] ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@sanjibansg sanjibansg deleted the docs_c++_uninvocable-compute-functions branch April 5, 2022 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidavidm lidavidm lidavidm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sanjibansg @ursabot @lidavidm