Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-15326: [C++] Fix Gandiva crashes #12145

Closed
wants to merge 1 commit into from

Conversation

pitrou
Copy link
Member

@pitrou pitrou commented Jan 13, 2022

  • Stack smashing crash because of excessive size given to utf8proc.
  • Heap access crash because of insufficient scratch space in levenshtein calculation.

- Stack smashing crash because of excessive size given to utf8proc.
- Heap access crash because of insufficient scratch space in levenshtein calculation.
@pitrou
Copy link
Member Author

pitrou commented Jan 13, 2022

@github-actions crossbow submit -g cpp

@pitrou
Copy link
Member Author

pitrou commented Jan 13, 2022

@augustoasilva @pravindra @ViniciusSouzaRoque Can you take a look?

@github-actions
Copy link

@github-actions
Copy link

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

@github-actions
Copy link

Revision: fdbf185

Submitted crossbow builds: ursacomputing/crossbow @ actions-1395

Task Status
test-build-cpp-fuzz Github Actions
test-conda-cpp Github Actions
test-conda-cpp-valgrind Azure
test-debian-10-cpp-amd64 Github Actions
test-debian-10-cpp-i386 Github Actions
test-debian-11-cpp-amd64 Github Actions
test-debian-11-cpp-i386 Github Actions
test-fedora-33-cpp Github Actions
test-ubuntu-18.04-cpp Github Actions
test-ubuntu-18.04-cpp-release Github Actions
test-ubuntu-18.04-cpp-static Github Actions
test-ubuntu-20.04-cpp Github Actions
test-ubuntu-20.04-cpp-14 Github Actions
test-ubuntu-20.04-cpp-17 Github Actions
test-ubuntu-20.04-cpp-bundled Github Actions
test-ubuntu-20.04-cpp-thread-sanitizer Github Actions

@pitrou pitrou requested a review from kszucs January 13, 2022 17:37
@pitrou
Copy link
Member Author

pitrou commented Jan 13, 2022

Note the test-fedora-33-cpp failure should be fixed by #12146

@ViniciusSouzaRoque
Copy link
Contributor

@augustoasilva @pravindra @ViniciusSouzaRoque Can you take a look?

ok, everything right with this change.

@kszucs kszucs closed this in fc6d408 Jan 14, 2022
@pitrou pitrou deleted the ARROW-15326-gandiva-crashes branch January 14, 2022 12:46
@ursabot
Copy link

ursabot commented Jan 14, 2022

Benchmark runs are scheduled for baseline = 99f7c3c and contender = fc6d408. fc6d408 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️2.69% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.04% ⬆️0.0%] ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants