Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-15316 [R] Make a one-function pointer function #12168

Closed
wants to merge 3 commits into from
Closed

ARROW-15316 [R] Make a one-function pointer function #12168

wants to merge 3 commits into from

Conversation

dragosmg
Copy link
Contributor

No description provided.

@dragosmg dragosmg marked this pull request as ready for review January 17, 2022 12:45
@github-actions
Copy link

https://issues.apache.org/jira/browse/ARROW-15316

@pitrou
Copy link
Member

pitrou commented Jan 18, 2022

@paleolimbot

paleolimbot
paleolimbot reviewed Jan 18, 2022
View reviewed changes
Copy link
Member

@paleolimbot paleolimbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much cleaner...looks great! Just one note about the name of the function.

r/R/python.R Outdated Show resolved Hide resolved
paleolimbot
paleolimbot reviewed Jan 18, 2022
View reviewed changes
r/R/python.R Outdated Show resolved Hide resolved
@dragosmg
forgot out
dc34f6f
@dragosmg
updated the function name backwards_compatible_pointer_double() -> …
0778f50 
…`pyarrow_compatible_pointer()` and moved version extraction and logic inside it
jonkeane
jonkeane approved these changes Jan 19, 2022
View reviewed changes
Copy link
Member

@jonkeane jonkeane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@jonkeane jonkeane closed this in a061c4c Jan 19, 2022
@ursabot
Copy link

ursabot commented Jan 19, 2022 •
edited

Benchmark runs are scheduled for baseline = 657d21a and contender = a061c4c. a061c4c is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.0% ⬆️0.36%] ursa-i9-9960x
[Finished ⬇️0.09% ⬆️0.0%] ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@dragosmg dragosmg deleted the make_a_one_function_pointer_function branch January 31, 2022 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paleolimbot paleolimbot paleolimbot left review comments

@jonkeane jonkeane jonkeane approved these changes

Assignees
No one assigned
Labels
Component: R
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dragosmg @pitrou @ursabot @jonkeane @paleolimbot