ARROW-15360: [Python] Check slice bounds in Buffer.slice() #12182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling Buffer.slice() with invalid arguments could return a Buffer referencing out-of-bounds memory. With this change, an IndexError is raised instead. Note that Buffer.__getitem__() is unaffected, as it applies Python slice semantics: indices out of bounds are automatically clamped.
pitrou
force-pushed
the
ARROW-15360-buffer-slice
branch
from
a157d2d
to
0b39245
Compare
|
Benchmark runs are scheduled for baseline = 09f23ed and contender = fd580db. fd580db is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
Buffer.slice()with invalid arguments could return a Buffer referencing out-of-bounds memory.With this change, an IndexError is raised instead.
Note that
Buffer.__getitem__()is unaffected, as it applies Python slice semantics: indices out of bounds are automatically clamped.