Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-15372: [C++][Gandiva] Gandiva now depends on boost/crc.hpp which is missing from the trimmed boost archive #12190

Closed
wants to merge 4 commits into from

Conversation

kszucs
Copy link
Member

@kszucs kszucs commented Jan 19, 2022

@github-actions
Copy link

@github-actions
Copy link

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

@kszucs
Copy link
Member Author

kszucs commented Jan 19, 2022

@github-actions crossbow submit test-ubuntu-20.04-cpp-bundled

First try to reproduce the error.

@github-actions
Copy link

Revision: 228fbdf

Submitted crossbow builds: ursacomputing/crossbow @ actions-1404

Task Status
test-ubuntu-20.04-cpp-bundled Github Actions

@apache apache deleted a comment from github-actions bot Jan 19, 2022
@kszucs
Copy link
Member Author

kszucs commented Jan 19, 2022

Issue reproduced, need to update the trimmed boost archive.

@kszucs
Copy link
Member Author

kszucs commented Jan 19, 2022

@github-actions crossbow submit test-ubuntu-20.04-cpp-bundled

Testing with the updated boost tarball boost_1_75_0.tar.gz available at the apache-arrow-7.0.0 tag in the ursa-labs/thirdparty repository.

@github-actions
Copy link

Revision: 9b9282f

Submitted crossbow builds: ursacomputing/crossbow @ actions-1405

Task Status
test-ubuntu-20.04-cpp-bundled Github Actions

@kszucs kszucs requested a review from kou January 19, 2022 20:50
@apache apache deleted a comment from github-actions bot Jan 19, 2022
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@@ -364,6 +364,9 @@ foreach(_VERSION_ENTRY ${TOOLCHAIN_VERSIONS_TXT})
set(${_VARIABLE_NAME} ${_VARIABLE_VALUE})
endforeach()

set(THIRDPARTY_MIRROR_URL
"https://github.com/ursa-labs/thirdparty/releases/download/apache-arrow-7.0.0")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can, but the boost tarball there is the previous trimmed version.

I was thinking to keep the github mirror so we can see how reliable jfrog is after the release.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. It makes sense.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though I've just set up the jfrog directory, so we can just simply switch to that.

@kszucs
Copy link
Member Author

kszucs commented Jan 19, 2022

@github-actions crossbow submit test-ubuntu-20.04-cpp-bundled

Let's try out artifactory.

@github-actions
Copy link

Revision: 575896e

Submitted crossbow builds: ursacomputing/crossbow @ actions-1407

Task Status
test-ubuntu-20.04-cpp-bundled Github Actions

@kou kou closed this in c535878 Jan 20, 2022
@ursabot
Copy link

ursabot commented Jan 20, 2022

Benchmark runs are scheduled for baseline = a061c4c and contender = c535878. c535878 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.09% ⬆️0.0%] ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants