Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-14419 [R] Add filter + join test #12208

Closed
wants to merge 2 commits into from
Closed

ARROW-14419 [R] Add filter + join test #12208

wants to merge 2 commits into from

Conversation

dragosmg
Copy link
Contributor

No description provided.

@github-actions
Copy link

https://issues.apache.org/jira/browse/ARROW-14419

paleolimbot
paleolimbot reviewed Jan 25, 2022
View reviewed changes
Copy link
Member

@paleolimbot paleolimbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! It would help to have a little more description on the test (I know that many of our tests don't have this).

r/tests/testthat/test-dplyr-join.R Outdated Show resolved Hide resolved
paleolimbot
paleolimbot approved these changes Jan 28, 2022
View reviewed changes
Copy link
Member

@paleolimbot paleolimbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@jonkeane jonkeane closed this in c5b757f Jan 28, 2022
@ursabot
Copy link

ursabot commented Jan 28, 2022 •
edited

Benchmark runs are scheduled for baseline = 07ec0a1 and contender = c5b757f. c5b757f is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.36% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.22% ⬆️0.04%] ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@dragosmg dragosmg deleted the filter_then_join_test branch January 31, 2022 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paleolimbot paleolimbot paleolimbot approved these changes

Assignees
No one assigned
Labels
Component: R
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dragosmg @ursabot @paleolimbot