Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-14816: [R] Implement bindings for lubridate::mday #12218

Closed
wants to merge 1 commit into from

Conversation

AlenkaF
Copy link
Member

@AlenkaF AlenkaF commented Jan 21, 2022

Adding a binding for lubridate::mday in expressions.R and a test for date and timestamp.

Note: day() is an aliase for mday() in lubridate.

@github-actions
Copy link

Copy link
Member

@thisisnic thisisnic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rok
Copy link
Member

rok commented Jan 21, 2022

Would this be a candidate for another c++ kernel?

@thisisnic thisisnic closed this in 3fa2d21 Jan 21, 2022
@thisisnic
Copy link
Member

Would this be a candidate for another c++ kernel?

@rok From my understanding it is already using a C++ kernel - day.

@ursabot
Copy link

ursabot commented Jan 21, 2022

Benchmark runs are scheduled for baseline = 584b360 and contender = 3fa2d21. 3fa2d21 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.09% ⬆️0.04%] ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@AlenkaF
Copy link
Member Author

AlenkaF commented Jan 21, 2022

@rok yes, Nic is correct. Note that the binding for day or mday map to the same C++ function day as they are aliases in lubridate.

@AlenkaF AlenkaF deleted the ARROW-14816 branch January 21, 2022 17:20
@rok
Copy link
Member

rok commented Jan 21, 2022

Ah, sorry for the noise :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants