ARROW-15441: [C++][Compute] Fix incorrect result of hash_count a null type column #12251
Conversation
Crystrix
changed the title
| } | ||
| } | ||
|
|
||
| TEST(GroupBy, CountWithNullTypeEmptyTable) { |
There was a problem hiding this comment.
Was there an issue with empty tables specifically that this is checking?
There was a problem hiding this comment.
No, it's just to make sure this corner case can be correctly processed.
|
Thanks for the fix! |
|
Benchmark runs are scheduled for baseline = c4eb8dc and contender = 0f820ef. 0f820ef is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
The result of hash_count such array is incorrect.
For a table like this:
The result is :
This PR handles null type with different count options.