ARROW-15451: [C++] Fix build with C++17 and ARROW_GCS=ON

[pitrou]

Bump the vendored google-cloud-cpp version so that CMAKE_CXX_STANDARD doesn't get ignored.

Also cleanup CMAKE_CXX_STANDARD handling in a few other places.

[pitrou]

@coryan Does this look ok to you?

[coryan]

Yes, this LGTM. At some point you may want to update the google-cloud-cpp dependency in vcpkg, just for consistency I think.

[pitrou]

Ok, I'll let @kszucs choose how to handle the vcpkg configuration.

[github-actions]

https://issues.apache.org/jira/browse/ARROW-15451

[kszucs]

Ok, I'll let @kszucs choose how to handle the vcpkg configuration.

Can't because we're not using the vcpkg versioning feature yet (because of various AWS SDK issues), so we have a specific vcpkg revision with a set of patches for those particular ports. If we'd switch to vcpkg versioning then the custom patching wouldn't work because vcpkg checks out each port's pinned git tree (struggled with it during the weekend).

We need to fix the vcpkg ports upstream and/or provide overlay ports (basically overriding certain ports) then we can switch to use vcpkg versioning, then we can bump ORC's version there.

[pitrou]

@kszucs We're already versioning google-cloud-cpp in vcpkg, aren't we?

    {
      "name":"google-cloud-cpp",
      "version>=": "1.32.1",
      "default-features": false,
      "features": [
        "storage"
      ]
    },

[kszucs]

@pitrou requires a cmake format

[kszucs]

@github-actions crossbow submit test-ubuntu-20.04-cpp-bundled

[pitrou]

Crossbow jobs at https://github.com/ursacomputing/crossbow/branches/all?query=pitrou-0

[github-actions]

Revision: 54d6ee5

Submitted crossbow builds: ursacomputing/crossbow @ actions-1488

Task	Status
test-ubuntu-20.04-cpp-bundled

[kszucs]

@kszucs We're already versioning google-cloud-cpp in vcpkg, aren't we?

    {
      "name":"google-cloud-cpp",
      "version>=": "1.32.1",
      "default-features": false,
      "features": [
        "storage"
      ]
    },

We have a new ci/vcpkg/vcpkg.json for the wheels.

[pitrou]

We have a new ci/vcpkg/vcpkg.json for the wheels.

Shouldn't it be folded back into the main one? The "features" thing looks useful.

[kszucs]

We have a new ci/vcpkg/vcpkg.json for the wheels.

Shouldn't it be folded back into the main one? The "features" thing looks useful.

Eventually yes, possibly for 8.0.

[pitrou]

Rebased.

[pitrou]

New Crossbow submission at https://github.com/ursacomputing/crossbow/branches/all?query=pitrou-2

[pitrou]

Also triggered Linux packaging Crossbow builds: https://github.com/ursacomputing/crossbow/branches/all?query=pitrou-3

[ursabot]

Benchmark runs are scheduled for baseline = 38d4d77 and contender = f70acb2. f70acb2 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.26% ⬆️0.09%] ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java