Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-15218: [C++] Add decimal support to the indices_nonzero compute function #12270

Closed
wants to merge 6 commits into from

Conversation

c-jamie
Copy link
Contributor

@c-jamie c-jamie commented Jan 26, 2022

Adds decimal support to the indices_nonzero compute function. This vector function returns the indices of an array that contains values !=0 or !=false.

This can be used in conjunction with existing functions that return a mask to get back the indices where the mask matches.

Have also added a small enhancement to the indices_nonzero tests to use a TYPED_TEST_SUITE for numeric primitives.

@github-actions
Copy link

@github-actions
Copy link

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

@pitrou pitrou changed the title ARROW-15218: [C++] add decimal support to the indices_nonzero compute function ARROW-15218: [C++] Add decimal support to the indices_nonzero compute function Jan 26, 2022
Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR! You'll find some comments below.

Also, can you please update the docs in this file?
https://github.com/apache/arrow/blob/master/docs/source/cpp/compute.rst#containment-tests-1

cpp/src/arrow/compute/kernels/vector_selection.cc Outdated Show resolved Hide resolved
cpp/src/arrow/compute/kernels/vector_selection.cc Outdated Show resolved Hide resolved
cpp/src/arrow/compute/kernels/vector_selection.cc Outdated Show resolved Hide resolved
cpp/src/arrow/compute/kernels/vector_selection_test.cc Outdated Show resolved Hide resolved
cpp/src/arrow/compute/kernels/vector_selection_test.cc Outdated Show resolved Hide resolved
cpp/src/arrow/compute/kernels/vector_selection_test.cc Outdated Show resolved Hide resolved
cpp/src/arrow/compute/kernels/vector_selection_test.cc Outdated Show resolved Hide resolved
Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you very much @c-jamie !

@c-jamie
Copy link
Contributor Author

c-jamie commented Jan 27, 2022

Amazing - thanks a mill @pitrou for helping me with this.

@pitrou pitrou closed this in ce0964e Jan 27, 2022
@ursabot
Copy link

ursabot commented Jan 27, 2022

Benchmark runs are scheduled for baseline = 09e4a5e and contender = ce0964e. ce0964e is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.36% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.35% ⬆️0.09%] ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@c-jamie c-jamie deleted the ARROW-15218-non-zero-decimal branch January 27, 2022 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants