New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-15218: [C++] Add decimal support to the indices_nonzero compute function #12270
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR! You'll find some comments below.
Also, can you please update the docs in this file?
https://github.com/apache/arrow/blob/master/docs/source/cpp/compute.rst#containment-tests-1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you very much @c-jamie !
Amazing - thanks a mill @pitrou for helping me with this. |
Benchmark runs are scheduled for baseline = 09e4a5e and contender = ce0964e. ce0964e is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Adds decimal support to the
indices_nonzero
compute function. This vector function returns the indices of an array that contains values!=0
or!=false
.This can be used in conjunction with existing functions that return a mask to get back the indices where the mask matches.
Have also added a small enhancement to the
indices_nonzero
tests to use aTYPED_TEST_SUITE
for numeric primitives.