Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-15477: [C++][Python] Allow to create (FixedSize/Large)ListArray from arrays and type #12312

Conversation

jorisvandenbossche
Copy link
Member

@jorisvandenbossche jorisvandenbossche commented Feb 1, 2022

This enables to create a ListArray in this way with a custom type (eg non-default field name). Mimics the interface we already have for MapArray::FromArrays as well.

@github-actions
Copy link

github-actions bot commented Feb 1, 2022

Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pitrou pitrou closed this in 74deb45 Feb 2, 2022
@jorisvandenbossche jorisvandenbossche deleted the ARROW-15477-list-from-arrays branch February 2, 2022 13:29
@ursabot
Copy link

ursabot commented Feb 2, 2022

Benchmark runs are scheduled for baseline = 9e8ac56 and contender = 74deb45. 74deb45 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.0% ⬆️0.71%] ursa-i9-9960x
[Finished ⬇️0.43% ⬆️0.04%] ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

vibhatha pushed a commit to vibhatha/arrow that referenced this pull request Feb 4, 2022
… from arrays and type

This enables to create a ListArray in this way with a custom type (eg non-default field name). Mimics the interface we already have for `MapArray::FromArrays` as well.

Closes apache#12312 from jorisvandenbossche/ARROW-15477-list-from-arrays

Authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants