New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-15546: [FlightRPC][C++] Remove quotes from cookie header #12327
Conversation
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW Opening JIRAs ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename pull request title in the following format?
or
See also: |
|
92df42c
to
2277fe2
Compare
The client cookie middleware should not wrap values in quotes when emitting the Cookie header.
2277fe2
to
f0899d3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Indeed, it appears quotes are acceptable in Set-Cookie but are not described for Cookie.
Benchmark runs are scheduled for baseline = 76decf6 and contender = d885d82. d885d82 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
The client cookie middleware should not wrap values in quotes when emitting the Cookie header. Closes apache#12327 from jduo/cookie-header-fix Authored-by: James Duong <jduong@dremio.com> Signed-off-by: David Li <li.davidm96@gmail.com>
The client cookie middleware should not wrap values in quotes when emitting the Cookie header. Closes apache#12327 from jduo/cookie-header-fix Authored-by: James Duong <jduong@dremio.com> Signed-off-by: David Li <li.davidm96@gmail.com>
The client cookie middleware should not wrap values in quotes when
emitting the Cookie header.