Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-15546: [FlightRPC][C++] Remove quotes from cookie header #12327

Closed
wants to merge 1 commit into from

Conversation

jduo
Copy link
Member

@jduo jduo commented Feb 3, 2022

The client cookie middleware should not wrap values in quotes when
emitting the Cookie header.

@github-actions
Copy link

github-actions bot commented Feb 3, 2022

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW

Opening JIRAs ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename pull request title in the following format?

ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

See also:

@jduo jduo changed the title [FlightRPC][C++] Remove quotes from cookie header ARROW-15546: [FlightRPC][C++] Remove quotes from cookie header Feb 3, 2022
@github-actions
Copy link

github-actions bot commented Feb 3, 2022

@github-actions
Copy link

github-actions bot commented Feb 3, 2022

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

The client cookie middleware should not wrap values in quotes when
emitting the Cookie header.
Copy link
Member

@lidavidm lidavidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Indeed, it appears quotes are acceptable in Set-Cookie but are not described for Cookie.

@lidavidm lidavidm closed this in d885d82 Feb 3, 2022
@ursabot
Copy link

ursabot commented Feb 3, 2022

Benchmark runs are scheduled for baseline = 76decf6 and contender = d885d82. d885d82 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.36% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.35% ⬆️0.43%] ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

vibhatha pushed a commit to vibhatha/arrow that referenced this pull request Feb 4, 2022
The client cookie middleware should not wrap values in quotes when
emitting the Cookie header.

Closes apache#12327 from jduo/cookie-header-fix

Authored-by: James Duong <jduong@dremio.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
kszucs pushed a commit to kszucs/arrow that referenced this pull request Mar 3, 2022
The client cookie middleware should not wrap values in quotes when
emitting the Cookie header.

Closes apache#12327 from jduo/cookie-header-fix

Authored-by: James Duong <jduong@dremio.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
@jduo jduo deleted the cookie-header-fix branch October 23, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants