Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-15648: [C++][Gandiva] Fix the size of the Gandiva cache #12394

Closed

Conversation

anthonylouisbsb
Copy link
Contributor

@anthonylouisbsb anthonylouisbsb commented Feb 10, 2022

Add a flag that was missing in that PR to add a flag related to the Object Code cache

Caching the entire projector/filter instead of object cache has a higher memory overhead so need to lower the size when not using object code caching.

@github-actions
Copy link

@github-actions
Copy link

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

@pravindra pravindra closed this in d4b690a Feb 11, 2022
@ursabot
Copy link

ursabot commented Feb 11, 2022

Benchmark runs are scheduled for baseline = fa69911 and contender = d4b690a. d4b690a is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.21% ⬆️0.0%] test-mac-arm
[Failed] ursa-i9-9960x
[Finished ⬇️0.09% ⬆️0.13%] ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@anthonylouisbsb anthonylouisbsb deleted the fixbug/fix-gandiva-cache-size branch February 11, 2022 19:16
vfraga pushed a commit to rafael-telles/arrow that referenced this pull request Mar 21, 2022
Add a flag that was missing in that PR to [add a flag related to the Object Code cache](apache#12308)

Caching the entire projector/filter instead of object cache has a higher memory overhead so need to lower the size when not using object code caching.

Closes apache#12394 from anthonylouisbsb/fixbug/fix-gandiva-cache-size

Authored-by: Anthony Louis <anthony@simbioseventures.com>
Signed-off-by: Pindikura Ravindra <ravindra@dremio.com>
vfraga pushed a commit to rafael-telles/arrow that referenced this pull request Mar 24, 2022
Add a flag that was missing in that PR to [add a flag related to the Object Code cache](apache#12308)

Caching the entire projector/filter instead of object cache has a higher memory overhead so need to lower the size when not using object code caching.

Closes apache#12394 from anthonylouisbsb/fixbug/fix-gandiva-cache-size

Authored-by: Anthony Louis <anthony@simbioseventures.com>
Signed-off-by: Pindikura Ravindra <ravindra@dremio.com>
vfraga pushed a commit to rafael-telles/arrow that referenced this pull request Mar 25, 2022
Add a flag that was missing in that PR to [add a flag related to the Object Code cache](apache#12308)

Caching the entire projector/filter instead of object cache has a higher memory overhead so need to lower the size when not using object code caching.

Closes apache#12394 from anthonylouisbsb/fixbug/fix-gandiva-cache-size

Authored-by: Anthony Louis <anthony@simbioseventures.com>
Signed-off-by: Pindikura Ravindra <ravindra@dremio.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants