-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] ARROW-15678: [C++][CI] a crossbow job with MinRelSize enabled #12422
Closed
Closed
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
8e62c82
This should fail cause MinRelSize is not yet fixed
jonkeane 9f4c751
add MinSizeRel to setupCxxFlags.cmake
jonkeane a04812d
oops
jonkeane 2939738
add ARROW_R_DEV to the global env
jonkeane 5a77aa9
oops, need to print
jonkeane 6c56a25
add extra flag
jonkeane 1910cdb
Experiment with other clang version
pitrou d483dcb
Also update where R looks for compilers
jonkeane e00bc0a
oops, need to create the directory first
jonkeane 20ca138
try gcc-11
jonkeane ffe6725
bundle deps to avoid gcc-clang mismatch
jonkeane 5d0f404
a different way of testing
jonkeane bfb7b85
skip some tests that complain about somethign unrelated
jonkeane 7900fa7
try only the parquet tests
jonkeane File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1255,6 +1255,14 @@ tasks: | |
ci: github | ||
template: r/github.linux.offline.build.yml | ||
|
||
test-r-minsizerel: | ||
ci: github | ||
template: r/github.macos-linux.local.yml | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This builds on macos + linux, which isn't strictly necessary for triggering what we're trying to trigger, but might be worth checking both linux + macos anyway |
||
params: | ||
env: | ||
CMAKE_BUILD_TYPE: MinSizeRel | ||
ARROW_R_DEV: TRUE | ||
EXTRA_CMAKE_FLAGS: '-DCMAKE_VERBOSE_MAKEFILE=on' | ||
|
||
{% for r_org, r_image, r_tag in [("rhub", "ubuntu-gcc-release", "latest"), | ||
("rocker", "r-base", "latest"), | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you make a separate (presumably minor) PR for this change + the arrow_info() addition?