Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-15688: [C++] add_checked doesn't error out on duration overflow #12438

Closed
wants to merge 2 commits into from

Conversation

rok
Copy link
Member

@rok rok commented Feb 16, 2022

This is to resolve ARROW-15688.

@github-actions
Copy link

@rok
Copy link
Member Author

rok commented Feb 16, 2022

@pitrou thanks for spotting that one!

@rok rok force-pushed the ARROW-15688 branch 2 times, most recently from fbdca2b to e707fa2 Compare February 16, 2022 11:06
Copy link
Contributor

@cyb70289 cyb70289 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@pitrou pitrou closed this in 4f890ab Feb 16, 2022
@ursabot
Copy link

ursabot commented Feb 16, 2022

Benchmark runs are scheduled for baseline = 07db461 and contender = 4f890ab. 4f890ab is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Failed] ec2-t3-xlarge-us-east-2
[Failed] test-mac-arm
[Failed] ursa-i9-9960x
[Failed] ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants