Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-15744: [Gandiva][C++] Add NEGATIVE function for interval types #12480

Conversation

Johnnathanalmeida
Copy link
Contributor

@Johnnathanalmeida Johnnathanalmeida commented Feb 21, 2022

There are two interval types:

YEAR_MONTH
DAY_TIME

This implementation is based on java implementation.

@github-actions
Copy link

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW

Opening JIRAs ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename pull request title in the following format?

ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

See also:

@Johnnathanalmeida Johnnathanalmeida changed the title [Gandiva][C++] Add NEGATIVE function for interval types ARROW-15744: [Gandiva][C++] Add NEGATIVE function for interval types Feb 21, 2022
@github-actions
Copy link

@github-actions
Copy link

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

@Johnnathanalmeida Johnnathanalmeida force-pushed the feature/add-negative-function-interval-types branch 6 times, most recently from 339bfb7 to bc2ecb7 Compare February 25, 2022 22:47
@Johnnathanalmeida
Copy link
Contributor Author

@github-actions crossbow submit java-jars

@github-actions
Copy link

Revision: 673f672

Submitted crossbow builds: ursacomputing/crossbow @ actions-1791

Task Status
java-jars Github Actions

@Johnnathanalmeida Johnnathanalmeida force-pushed the feature/add-negative-function-interval-types branch from dc81dff to 68c92a0 Compare April 26, 2022 16:52
@Johnnathanalmeida Johnnathanalmeida force-pushed the feature/add-negative-function-interval-types branch from a82acaa to a66f568 Compare April 26, 2022 21:19
@pravindra pravindra closed this in e948153 Apr 27, 2022
@ursabot
Copy link

ursabot commented May 2, 2022

Benchmark runs are scheduled for baseline = 0933fac and contender = e948153. e948153 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.04% ⬆️0.0%] test-mac-arm
[Failed ⬇️0.71% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.04% ⬆️0.04%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] e9481532 ec2-t3-xlarge-us-east-2
[Finished] e9481532 test-mac-arm
[Failed] e9481532 ursa-i9-9960x
[Finished] e9481532 ursa-thinkcentre-m75q
[Finished] 0933facc ec2-t3-xlarge-us-east-2
[Finished] 0933facc test-mac-arm
[Finished] 0933facc ursa-i9-9960x
[Finished] 0933facc ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ursabot
Copy link

ursabot commented May 2, 2022

['Python', 'R'] benchmarks have high level of regressions.
ursa-i9-9960x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants