Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-15746: [Release][Java] Add missing artifacts to tasks.yml #12481

Conversation

BryanCutler
Copy link
Member

@BryanCutler BryanCutler commented Feb 21, 2022

This adds the new arrow-flight parent POM and so on to the list of artifacts to deploy in tasks.yml

@BryanCutler BryanCutler requested a review from kou February 21, 2022 17:42
@github-actions
Copy link

@github-actions
Copy link

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

@BryanCutler
Copy link
Member Author

I would like to run this to verify, but I couldn't get crossbow setup correctly and keep getting errors. If there is an easier way to test this out, let me know.

@BryanCutler
Copy link
Member Author

@kou or @kszucs has there been any thought on making this list of java artifacts dynamically so we don't forget to add something in the future?

@kou
Copy link
Member

kou commented Feb 21, 2022

@github-actions crossbow submit java-jars

@github-actions
Copy link

Revision: af7d3e2

Submitted crossbow builds: ursacomputing/crossbow @ actions-1664

Task Status
java-jars Github Actions

@kou
Copy link
Member

kou commented Feb 21, 2022

We can verify this by the following command lines:

$ git clone https://github.com/ursacomputing/crossbow.git
$ archery crossbow --github-token "${GITHUB_TOKEN}" --queue-path $(pwd)/crossbow status actions-1664

@kou
Copy link
Member

kou commented Feb 21, 2022

Thanks.

It seems that there are more missing entries:

https://github.com/ursacomputing/crossbow/releases/nightly-2022-02-21-0-github-java-jars

  • flight-integration-tests-*
  • flight-sql-*

Could you also add them in this pull request or separated pull request?

@BryanCutler
Copy link
Member Author

Ah, I thought I was supposed to create an empty crossbow repo. No wonder why I had issues 😞 I'll try it out with a fork from ursa, that should work.

@BryanCutler
Copy link
Member Author

BryanCutler commented Feb 22, 2022

Hmm, something doesn't seem right. Still not picking up flight-sql and integration-tests.
Nvm, I see you have to submit the job first and then check the status..

@kou
Copy link
Member

kou commented Feb 22, 2022

We need to re-run @github-actions crossbow submit java-jars after we change tasks.yml.

@BryanCutler
Copy link
Member Author

@github-actions crossbow submit java-jars

@github-actions
Copy link

Revision: 72b02f8

Submitted crossbow builds: ursacomputing/crossbow @ actions-1665

Task Status
java-jars Github Actions

@BryanCutler
Copy link
Member Author

@github-actions crossbow submit java-jars

@github-actions
Copy link

Revision: 9e52535

Submitted crossbow builds: ursacomputing/crossbow @ actions-1666

Task Status
java-jars Github Actions

@BryanCutler
Copy link
Member Author

@kou looking at the logs of the latest run, it uploads all the artifacts now. Is it possible to download the ones from these crossbow tasks for a final check? I couldn't tell exactly where they get uploaded to.

@kou kou changed the title ARROW-15746: [Java] Add arrow-flight pom artifact to tasks.yml ARROW-15746: [Release][Java] Add missing artifacts to tasks.yml Feb 22, 2022
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

I confirmed that we can upload all artifacts with this change.

@kou kou closed this in bee67c5 Feb 22, 2022
@ursabot
Copy link

ursabot commented Feb 22, 2022

Benchmark runs are scheduled for baseline = 50ed858 and contender = bee67c5. bee67c5 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.21% ⬆️0.04%] test-mac-arm
[Failed ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️1.49% ⬆️0.0%] ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@BryanCutler BryanCutler deleted the java-add-arrow-flight-pom-ARROW-15746 branch February 23, 2022 00:09
@BryanCutler
Copy link
Member Author

Thanks @kou ! Is there a maintenance branch for 7.0 to backport so we can get these artifacts for 7.0.1?

@kou
Copy link
Member

kou commented Feb 23, 2022

We can just add 7.0.1 to Fix Version/s on JIRA. Our release tool merge needed commits by the information.

BTW, we don't decide that we release 7.0.1 yet. If you want 7.0.1, please start a discussion on the mailing list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants